[nrf fromlist] dts: nordic: nrf54h20: Fix exmif node definition #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the "snps,designware-spi" compatible from the EXMIF node in nRF54H20i, as the spi_dw driver cannot be used for this peripheral without Nordic-specific modifications that are not present upstream. An attempt to do so (just setting CONFIG_SPI=y will cause that, as the driver initialization function will be executed then) results in a bus fault. Signed-off-by: Andrzej Głąbek <[email protected]> (cherry picked from commit 4db5898e505c2447120b7d4e358836405451fac5) Upstream PR: zephyrproject-rtos/zephyr#72928
This is a follow-up to commit 7ea6937. Add the "snps,designware-spi" compatible to the EXMIF node so that the peripheral can be used with the spi_dw driver specially modified for that purpose. Signed-off-by: Andrzej Głąbek <[email protected]>
e-rk
approved these changes
May 17, 2024
masz-nordic
approved these changes
May 17, 2024
|
The commits went in with upmerge in #1721. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the "snps,designware-spi" compatible from the EXMIF node in nRF54H20i, as the spi_dw driver cannot be used for this peripheral without Nordic-specific modifications that are not present upstream. An attempt to do so (just setting CONFIG_SPI=y will cause that, as the driver initialization function will be executed then) results in a bus fault.
Upstream PR: zephyrproject-rtos/zephyr#72928
The compatible is restored in the second [noup] commit, so that the EXMIF can be used with the modified spi_dw driver in NCS.