chore: update dependencies #1362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
added
the
Contribution from BBC
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release52 #1362 +/- ##
=============================================
- Coverage 56.44% 55.76% -0.69%
=============================================
Files 401 360 -41
Lines 72109 66876 -5233
Branches 4547 3817 -730
=============================================
- Hits 40705 37291 -3414
+ Misses 31155 29454 -1701
+ Partials 249 131 -118 ☔ View full report in Codecov by Sentry. |
nytamin
approved these changes
Jan 22, 2025
| @@ -446,6 +446,7 @@ export async function handleDisableNextPiece(context: JobContext, data: DisableN | |||
|
|
|||
| return sortedPieces.find((piece) => { | |||
| return ( | |||
| piece.pieceInstance.piece.enable.start !== 'now' && | |||
There was a problem hiding this comment.
This is not a part of dependency updates, right? Is this a bug fix, and for what?
There was a problem hiding this comment.
Updated typescript complained about not being able to compare a string and number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Code improvement
New Behavior
This is a large round of dependency updates.
Some 'big' changes:
eventemitter3uses with builtin typed eventemitterMany of these tasks have been put off for a while as they needed nodejs newer than v14, so has been blocked until the meteor update last year.
Everything appears to be working fine, I haven't stressed it much though.
Testing
Affected areas
Time Frame
Other Information
Status