Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade required node version to ">=18.12", since blueprints… #3

Closed
wants to merge 2 commits into from

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Jan 26, 2024

I had some issues when installing a clean project. From reading the yarn docs we should include the yarn script itself like this.

Review instructions

Please test a clean install an ensure that this works for you

@nytamin nytamin requested review from jstarpl and Julusian January 26, 2024 06:07
@nytamin nytamin marked this pull request as draft January 26, 2024 13:06
@nytamin nytamin closed this Jan 26, 2024
@Julusian
Copy link
Contributor

I want to understand why this is necessary, the docs suggest flow is no longer necessary https://yarnpkg.com/blog/release/4.0#installing-yarn. And when creating new projects this yarn file does not get added

@nytamin
Copy link
Contributor Author

nytamin commented Jan 26, 2024

Not planning to merge this, but leaving it here for posterity in case anyone else have the same issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants