Validate ITRF structure instead of maintaining a support list #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, make it so that pandera actually validates constraints! Using the covariant type approach was resulting in validations not running.
trey-stafford
force-pushed
the
itrf-validation
branch
from
4d56cb0 to
026c566
Compare
mfisher87
reviewed
Aug 19, 2024
| @@ -110,6 +110,7 @@ ignore = [ | |||
| "EM101", # Exceptions should not use string literals | |||
| "SIM108", # Use ternary operator. Sometimes this is less readable. | |||
| "T201", # Remove 'print' statements. Sometimes these are handy. | |||
| "SIM105", # Use contextlib.suppress instead of try-except-pass. The recommended approach is slower and less flexible. | |||
There was a problem hiding this comment.
I dislike this rule too. We have an open PR on icepyx where we're discussing this! icesat2py/icepyx#572
mfisher87
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, make it so that pandera actually validates constraints! Using the covariant type approach was resulting in validations not running.
Resolves #7