Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename package (namespaced), build for and publish to PyPI #15

Merged
merged 13 commits into from
Aug 20, 2024
Merged

Rename package (namespaced), build for and publish to PyPI #15

merged 13 commits into from
Aug 20, 2024

Conversation

mfisher87
Copy link
Contributor

No description provided.

@mfisher87 mfisher87 marked this pull request as draft August 20, 2024 16:30
@mfisher87
Copy link
Contributor Author

I'ma do a pass on docs.

@mfisher87 mfisher87 marked this pull request as ready for review August 20, 2024 16:38
@mfisher87
Copy link
Contributor Author

@trey-stafford the new contributing instructions are tested with the end-to-end test. This package doesn't need any system libraries as far as I can tell, the h5py version compiled for PyPI includes the latest compiled hdf5 library. 💯

@mfisher87 mfisher87 marked this pull request as draft August 20, 2024 20:43
@mfisher87 mfisher87 force-pushed the pypi-release branch 3 times, most recently from 3811792 to e43542f Compare August 20, 2024 21:37
@mfisher87 mfisher87 marked this pull request as ready for review August 20, 2024 21:43
@trey-stafford
Copy link
Contributor

@trey-stafford the new contributing instructions are tested with the end-to-end test. This package doesn't need any system libraries as far as I can tell, the h5py version compiled for PyPI includes the latest compiled hdf5 library. 💯

Nice! I don't think gdal will be needed for this library either.

trey-stafford
trey-stafford requested changes Aug 20, 2024
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
src/nsidc/iceflow/data/models.py Outdated Show resolved Hide resolved
tests/unit/test_data_models.py Outdated Show resolved Hide resolved
@mfisher87 mfisher87 changed the title Build for and publish to PyPI Rename package (namespaced), build for and publish to PyPI Aug 20, 2024
@mfisher87 mfisher87 mentioned this pull request Aug 20, 2024
Closed
3 tasks
@mfisher87 mfisher87 merged commit e16bc84 into main Aug 20, 2024
4 checks passed
@mfisher87 mfisher87 deleted the pypi-release branch August 20, 2024 23:20
trey-stafford added a commit that referenced this pull request Aug 23, 2024
@trey-stafford
Remove conda-lock
e88ffe3 
conda environment.yml file was removed in
#15. We're now using pip to manage and
install deps
@trey-stafford trey-stafford mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trey-stafford trey-stafford trey-stafford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfisher87 @trey-stafford