Skip to content

Commit

Permalink
use xvfb not xephyr for automated tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@ntBre
ntBre committed Dec 5, 2024
1 parent cc1d060 commit 60743ca
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/main.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2920,8 +2920,7 @@ mod tests {
#[test]
fn main() {
// setup xephyr
let mut cmd =
Command::new("Xephyr").arg("-ac").arg(":1").spawn().unwrap();
let mut cmd = Command::new("Xvfb").arg(":1").spawn().unwrap();

Check failure on line 2923 in src/main.rs

View workflow job for this annotation

GitHub Actions / clippy

spawned process is never `wait()`ed on 

error: spawned process is never `wait()`ed on
    --> src/main.rs:2923:23
     |
2923 |         let mut cmd = Command::new("Xvfb").arg(":1").spawn().unwrap();
     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: consider calling `.wait()`
     = note: not doing so might leave behind zombie processes
     = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes
     = note: `-D clippy::zombie-processes` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::zombie_processes)]`

// wait for xephyr to start
unsafe {
Expand Down

0 comments on commit 60743ca

Please sign in to comment.