Fix: [Input] Vue Compat: deprecation INSTANCE_ATTRS_CLASS_STYLE (#16) #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kikuomax is this PR ready for me to review? |
@wesdevpro Yes, please! |
|
Due to #192, I have to rebase my fork. |
- `Input` introduces a new prop `compat-fallthrough` that determines if `class`, `style`, and `id` attributes are applied to the root `<div>` element, instead of the underlying `<input>` or `<textarea>`. Since Vue 3 changed the fallthrough behavior, `Input` became incompatible with Buefy for Vue 2. Setting the prop to `true`, makes `Input` compatible with Buefy for Vue 2. The default value for this prop is configured by a new config option `defaultInputCompatFallthrough`, which is `true` by default. issue ntohq#16
- Tests the new prop `compat-fallthrough` of `Input`.
- `CHANGELOG.md` is not well-structured for now, though, it is important to leave any clues for coming release.
- Refreshes test snapshots affected by the introduction of `compat-fallthrough` prop of `Input`.
- Renames `defaultInputCompatFallthrough` to `defaultCompatFallthrough` because there are many other components affected by the same Vue 3 change in attribute fallthrough behavior. I think having different config options for individual components is tedious for both users and maintainers. If one wants to apply different behavior to different components, can explicitly use `compat-fallthrough`. See ntohq#16 (comment)
kikuomax
force-pushed
the
input-fallthrough-behavior
branch
from
ea5bf77 to
5f8a9fc
Compare
Rebased! |
wesdevpro
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Proposed Changes
compat-fallthroughtoInput, which determines ifclass,style, andidattributes are applied to the root<div>element instead of the underlying<input>or<textarea>element. Iftrue, they are applied to the root<div>element, which is compatible with Vue 2.defaultCompatFallthroughto provide the default value for thecompat-fallthroughpropcompat-fallthroughpropcompat-fallthroughprop in theInputdoc pagecompat-fallthroughprop as a new feature toCHANGELOGcompat-fallthroughprop