-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated BSkeleton to Vue 3 functional component as function #197
Conversation
@hirokiky Thank you for your PR! Could you |
9243ce6
to
393f695
Compare
@kikuomax Thanks for your review! |
@hirokiky Thanks for the updates. I remember functional components will cause a problem in production unless we carefully treat them. Could you also update the following line?
Like I did in: buefy-next/packages/buefy-next/src/components/menu/index.js Lines 10 to 12 in 4905bd9
|
@kikuomax Thank you! |
undefined/null will be normalized as comment VNode inside Vue runtime. So we don't need to take care of it explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Proposed Changes
Vue 3 won't allow to return empty values, so now it will return CommentVNode when deactivatedI refered ModelList.vue changes for this commit
buefy@f85445f