Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [BreadcrumbItem] Vue Compat: deprecation INSTANCE_ATTRS_CLASS_STYLE #16 #209

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Fix: [BreadcrumbItem] Vue Compat: deprecation INSTANCE_ATTRS_CLASS_STYLE #16 #209

merged 4 commits into from
Mar 31, 2024

Conversation

kikuomax
Copy link
Collaborator

@kikuomax kikuomax commented Mar 22, 2024 •
edited
Loading

Related issue

Proposed Changes

  • Introduce a new prop compat-fallthrough to BreadcrumbItem, which determines if the class, style, and id attributes are applied to the root <li> element or the underlying tag. If true, they are applied to the root <li> element, which is compatible with Buefy for Vue 2.
  • Add new test cases for the compat-fallthrough prop of BreadcrumbItem
  • Explain the compat-fallthrough prop in the BreadcrumbItem doc page
  • Introduce the compat-fallthrogh prop of BreadcrumbItem as a new feature in CHANGELOG

kikuomax added 4 commits March 22, 2024 12:17
@kikuomax
feat(lib): add compat fallthrough prop to BreadcrumbItem
0c0611b 
- `BreadcrumbItem` introduces a new prop `compat-fallthrough` which
  determines if the `style`, `class`, and `id` attributes falls through
  to the root `<li>` element rather than the underlying tag. Since Vue 3
  changed the fallthrough behavior, `BreadcrumbItem` became incompatible
  with that of Buefy for Vue 2. The default value for this prop is
  configured by the `defaultCompatFallthrough` config option, which is
  `true` by default.
@kikuomax
test(lib): test BreadcrumbItem fallthrough behavior
2b2c116 
- Tests the new prop `compat-fallthrough` of `BreadcrumbItem`
@kikuomax
chore(docs): explain compat-fallthrough of BreadcrumbItem
01c5a40
@kikuomax
docs(CHANGELOG): explain compat-fallthrough of BreadcrumbItem
26c45cd
@kikuomax kikuomax requested a review from wesdevpro March 22, 2024 03:37
@kikuomax kikuomax mentioned this pull request Mar 22, 2024
Closed
@kikuomax kikuomax merged commit 3cfc599 into ntohq:dev Mar 31, 2024
3 checks passed
@kikuomax kikuomax deleted the breadcrumbitem-compat-fallthrough branch March 31, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesdevpro wesdevpro wesdevpro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kikuomax @wesdevpro