Fix [Clockpicker, Timepicker]: Vue Compat: deprecation INSTANCE_ATTRS_CLASS_STYLE (#16) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `TimepickerMixin` mixes in `CompatFallthroughMixin`, because both hosts `Clockpicker` and `Timepicker` provide fallthrough behavior.
- `Clockpicker` introduces a new prop `compat-fallthrough`, which determines if the `class`, `style`, and `id` attributes are applied to the root `<div>` element or the underlying `BInput` component. Since Vue 3 changed the fallthrough behavior, `Clockpicker` became incompatible with that of Buefy for Vue 2. The default value of this prop is configured by the `defaultCompatFallthrough` config option, which is `true` by default.
- Tests the fallthrough behavior of `Clockpicker`
- `Timepicker` introduces a new prop `compat-fallthrough`, which determines if the `class`, `style`, and `id` attributes are applied to the root `<div>` element or the underlying `BInput` component. Since Vue 3 changed the fallthrough behavior, `Timepicker` became incompatible with that of Buefy for Vue 2. The default value for this prop is configured by the `defaultCompatFallthrough` config option, which is `true` by default.
- Tests the fallthrough behavior of `Timepicker`
wesdevpro
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Proposed Changes
compat-fallthroughtoClockpickerandTimepicker, which determines if theclass,style, andidattributes are applied to the root<div>element or the underlying<b-input>component. Iftrue, they are applied to the root<div>element, which is compatible with Buefy for Vue 2.TimepickerMixinmixes inCompatFallthroughMixin, which bothClockpickerandTimepickermix incompat-fallthroughprop ofClockpickerandTimepickercompat-fallthroughprop in the doc pages ofClockpickerandTimepickercompat-fallthroughprop ofClockpickerandTimepickeras a new feature inCHANGELOG