Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [Datepicker]: Vue Compat: deprecation INSTANCE_ATTRS_CLASS_STYLE (#16) #211

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Fix [Datepicker]: Vue Compat: deprecation INSTANCE_ATTRS_CLASS_STYLE (#16) #211

merged 4 commits into from
Mar 26, 2024

Conversation

kikuomax
Copy link
Collaborator

Related issue:

Proposed Changes

  • Introduce a new prop compat-fallthrough to Datepicker, which determines if the class, style, and id attributes are applied to the root <div> element or the underlying <b-input> component. If true, they are applied to the root <div> element, which is compatible with Buefy for Vue 2.
  • Add new test cases for the compat-fallthrough prop Datepicker
  • Explain the compat-fallthrough prop in the Datepicker documentation page
  • Introduce the compat-fallthrough prop of Datepicker as a new feature in CHANGELOG

kikuomax added 4 commits March 25, 2024 12:00
@kikuomax
feat(lib): add compat-fallthrough prop to Datepicker
52c223d 
- `Datepicker` introduces a new prop `compat-fallthrough` which
  determines if the `class`, `style`, and `id` attributes are applied to
  the root `<div>` element or the underlying `<b-input>` component.
  Since Vue 3 changed the fallthrough behavior, `Datepicker` became
  incompatible with that of Buefy for Vue 2. The default value of this
  prop is determined by the `defaultCompatFallthrough` config option
  that is `true` by default.
@kikuomax
test(lib): test Datepicker fallthrough behavior
c7fc880 
- Adds new test cases that test the new `compat-fallthrough` prop of
  `Datepicker`
@kikuomax
chore(docs): explain compat-fallthrough prop of Datepicker
56d0dd9
@kikuomax
docs(CHANGELOG): explain compat-fallthrough prop of Datepicker
b2a5b82
@kikuomax kikuomax requested a review from wesdevpro March 25, 2024 03:21
@kikuomax kikuomax mentioned this pull request Mar 25, 2024
Closed
wesdevpro
wesdevpro approved these changes Mar 26, 2024
View reviewed changes
Copy link

@wesdevpro wesdevpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏍💨

@kikuomax kikuomax merged commit bb8d7f8 into ntohq:dev Mar 26, 2024
3 checks passed
@kikuomax kikuomax deleted the datepicker-compat-fallthrough branch March 26, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesdevpro wesdevpro wesdevpro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kikuomax @wesdevpro