Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [MenuItem]: Vue Compat: deprecation INSTANCE_ATTRS_CLASS_STYLE (#16) #212

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Fix [MenuItem]: Vue Compat: deprecation INSTANCE_ATTRS_CLASS_STYLE (#16) #212

merged 4 commits into from
Mar 28, 2024

Conversation

kikuomax
Copy link
Collaborator

Related issue:

Proposed Changes

  • Introduce a new prop compat-fallthrough to MenuItem, which determines if the class, style, and id attributes are applied to the root <li> element or the underlying tag. If true, they are applied to the root <li> element, which is compatible with Buefy for Vue 2.
  • Add new test cases for the compat-fallthrough prop of MenuItem
  • Explain the compat-fallthrough prop in the MenuItem documentation page
  • Introduce the compat-fallthrough prop of MenuItem as a new feature in CHANGELOG

kikuomax added 4 commits March 25, 2024 12:33
@kikuomax
feat(lib): add compat-fallthrough prop to MenuItem
06a08f5 
- `MenuItem` introduces a new prop `compat-fallthrough` that determines
  if the `class`, `style`, and `id` attributes are applied to the root
  `<li>` element or the underlying tag. Since Vue 3 changed the
  fallthrough behavior, `MenuItem` became incompatible with that of
  Buefy for Vue 2. The default value of this prop is determined by the
  `defaultCompatFallthrough` config option that is `true` by default.
@kikuomax
test(lib): test MenuItem fallthrough behavior
78cfa2a 
- Adds test cases for the `compat-fallthrough` prop of `MenuItem`
@kikuomax
chore(docs): explain compat-fallthrough prop of MenuItem
028e748
@kikuomax
docs(CHANGELOG): explain compat-fallthrough prop of MenuItem
ea5889c
@kikuomax kikuomax requested a review from wesdevpro March 25, 2024 03:48
@kikuomax kikuomax mentioned this pull request Mar 25, 2024
Closed
@kikuomax kikuomax merged commit 97c9524 into ntohq:dev Mar 28, 2024
3 checks passed
@kikuomax kikuomax deleted the menuitem-compat-fallthrough branch March 28, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesdevpro wesdevpro wesdevpro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kikuomax @wesdevpro