Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [Table]: Vue Compat: deprecation INSTANCE_ATTRS_CLASS_STYLE (#16) #217

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Fix [Table]: Vue Compat: deprecation INSTANCE_ATTRS_CLASS_STYLE (#16) #217

merged 4 commits into from
Mar 29, 2024

Conversation

kikuomax
Copy link
Collaborator

Related issue:

Proposed Changes

  • Introduce a new prop compat-fallthrough to Table, which determines if the class, style, and id attributes are applied to the root <div> element or the underlying pagination components. If true, they are applied to the root <div> element, which is compatible with Buefy for Vue 2.
  • Add test cases for the compat-fallthrough prop of Table
  • Explain the compat-fallthrough prop in the Table documentation page
  • Introduce the compat-fallthrough prop of Table as a new feature in CHANGELOG

kikuomax added 4 commits March 26, 2024 10:49
@kikuomax
feat(lib): add compat-fallthrough prop to Table
2f5daf0 
- `Table` introduces a new prop `compat-fallthrough` which determines if
  the `class`, `style`, and `id` attributes are applied to the root
  `<div>` element or the underlying `<b-table-pagination>` components.
  Since Vue 3 changed the fallthrough behavior, `Table` became
  incompatible with that of Buefy for Vue 2. The default value of this
  prop is given by the `defaultCompatFallthrough` config option that is
  `true` by default (compatible with Buefy for Vue 2).
@kikuomax
test(lib): test Table fallthrough behavior
b781954 
- Adds test cases for the `compat-fallthrough` prop of `Table`
@kikuomax
chore(docs): explain compat-fallthrough prop of Table
51f4122
@kikuomax
docs(CHANGELOG): explain compat-fallthrough prop of Table
5813ceb
@kikuomax kikuomax requested a review from wesdevpro March 26, 2024 02:04
@kikuomax kikuomax mentioned this pull request Mar 26, 2024
Closed
wesdevpro
wesdevpro approved these changes Mar 29, 2024
View reviewed changes
Copy link

@wesdevpro wesdevpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kikuomax kikuomax merged commit 8addee9 into ntohq:dev Mar 29, 2024
3 checks passed
@kikuomax kikuomax deleted the table-compat-fallthrough branch March 29, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesdevpro wesdevpro wesdevpro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kikuomax @wesdevpro