Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript Rollout Tier 14 - docs CodepenEdit #394

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

kikuomax
Copy link
Collaborator

Related issues:

Proposed Changes

  • Migration of packages/docs/src/components/CodepenEdit

Rewrites `src/components/CodepenEdit.vue` in TypeScript:
- Makes `code` required so that null checks are unnecessary

A tip for TypeScript migration:
- Explicitly import and register Buefy components so that they are
  type-checked. Note that no type-checking is performed for globally
  registered components.
@kikuomax kikuomax requested a review from wesdevpro January 15, 2025 13:44
@kikuomax kikuomax merged commit 18e17dc into ntohq:dev Jan 16, 2025
18 checks passed
@kikuomax kikuomax deleted the ts-rollout-tier-14-docs-codepen-edit branch January 16, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants