TypeScript Rollout Tier 16 - docs cleavejs #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrites the Cleave.js example in the `src/pages/extensions/cleavejs` in TypeScript. Includes overlooked Vue 2 → 3 migration. In `examples/ExFormat.vue`: - Rewrites the `cleave` directive so that it satisfies the Vue 3 API: - `bind` → `beforeMount` - `unbind` → `unmounted` - Removes `name` - Introduces a new interface `CleaveContainer` to facilitate accessing the `_vCleave` field attached to the input element - Removes the `.native` modifier from the `@input` event binding, because it is no longer necessary in Vue 3 In `Cleavejs.vue`: - Wraps `ExFormat` in `shallowRef` to resolve the warning about making a component reactive A tip for TypeScript migration: - Explicitly import and register Buefy components so that they are type-checked. Note that no type-checking is performed for globally registered components.
wesdevpro
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Proposed Changes
packages/docs/src/pages/extensions/cleavejs