Fix: [SlotComponent] Lifecycle hook won't be removed in Vue 3.5 #274 #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the `event` prop, and all the tricks to programmatically add / remove an event listener to / from the underlying Vue component. As far as I tested, there is no need to explicitly call `$forceUpdate` when the underlying Vue component is updated.
Removes meaningless tests from `src/utils/SlotComponent.spec.ts`. They became obsolete because the `event` prop, and the related tricks were removed from `SlotComponent`.
wesdevpro
approved these changes
Feb 2, 2025
|
@kikuomax is there any documentation that needs to be removed from the doc website? |
@wesdevpro No, it is an internal component. And the removed functionality was not open to users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Table, andTabscaused memory leaks on Vue 3.5.SlotComponentthatTable, andTabsinternally use gave up the tricky code that caused a memory leak on Vue 3.5. The removed code programmatically added an update hook to the component specified to thecomponentprop, but Vue 3.5 no longer provided a way to remove the update hook. As far as I tested, the update hook was unnecessary, and I decided to remove the code. I also removed test cases which became obsolete by this change.