Skip to content

Commit

Permalink
Moved ndpi_private.h to include directory
Browse files Browse the repository at this point in the history
  • Loading branch information
@lucaderi
lucaderi committed Jan 9, 2024
1 parent 3d57dec commit 4f9a08c
Showing 1 changed file with 0 additions and 0 deletions.
0 src/lib/ndpi_private.h → src/include/ndpi_private.h
View file
File renamed without changes.

2 comments on commit 4f9a08c

@utoni
Copy link
Collaborator

@utoni utoni commented on 4f9a08c Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why ndpi_private.h is a public header? I think this literally destroys the "private-ness" of ndpi_private.h, because it is shipped again to everyone and their grandma.

@IvanNardi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the idea, indeed; putting the header out of the header directory seemed a simpler solution than updating all the packaging scripts to ignore the private header.... :(

Please sign in to comment.