Handling of FaultedTxs after tx broadcasted #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling the different types of txs appropriately.
…e in providing a callback to alert the user about pausing. Move queue_transaction to _Machine instead - more applicable there since internals of _Machine are used. Move exposed functions to their own section in _Machine.
…any processing for this execution round of the machine; reasses during next execution round.
Pause will cause the looping task to stop (sleep), and resume will cause the looping task to start (wake). Idle state itself does not need processing, just setting of the interval when it is transitioned into.
… a tx got queued, OR we are in pause and need to be woken up.
…aused; all is still fine.
Add tests for _wake.
…ove to the PAUSED state instead of waiting until next iteration of looping call.
…a specialized case of it. TransactionFault -> TransactionFaulted
…aultedTx from that; simpler than taking values from exception the passing it along etc. Also ensures that faulted tx is indeed the same as the active tx as an added bit of validation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 81.30% 84.97% +3.66%
==========================================
Files 13 13
Lines 920 1038 +118
==========================================
+ Hits 748 882 +134
+ Misses 172 156 -16 ☔ View full report in Codecov by Sentry. |
derekpierre
force-pushed
the
its-all-your-fault
branch
2 times, most recently
from
a4114a5 to
88caca6
Compare
derekpierre
force-pushed
the
its-all-your-fault
branch
from
88caca6 to
14a66e2
Compare
derekpierre
changed the title
KPrasch
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based over #16
Fixes #11