Code

Limit Requeues/Retries#26

Code

Merged

52 commits merged intonucypher:mainnucypher/ATxM:mainfrom derekpierre:retriesderekpierre/ATxM:retriesCopy head branch name to clipboardMar 11, 2024

+1,499-197

Commits

Commits on Mar 4, 2024

• AsyncTxStrategy should do one of the following during execute: raise TransactionFaulted for unrecoverable/don't bother retrying errors, return updated params for an updated retry, or None if the st…

  Show description for 73e3e0e
  derekpierre

  committed
  73e3e0e

  Copy full SHA for 73e3e0e

• Adjust strategies to accomodate latest paradigm for execute i.e. return None if the machine should do nothing and wait based on this strategy.

  Show description for 013279c
  derekpierre

  committed
  013279c

  Copy full SHA for 013279c

• Adjust existing strategy tests since None can now be returned from execute().

  derekpierre

  committed
  9c2ec6e

  Copy full SHA for 9c2ec6e

• Update timeout strategy logging.

  derekpierre

  committed
  39b4b36

  Copy full SHA for 39b4b36

• Update speedup strategy calcs to use math.ceil instead of round

  Show description for cf88810
  derekpierre

  committed
  cf88810

  Copy full SHA for cf88810

• Move from a fixed max tip to a max tip factor based on the current suggested tip as a way to limit the speedup strategy getting out of control.

  Show description for 1c01980
  derekpierre

  committed
  1c01980

  Copy full SHA for 1c01980

• Simplify legacy transaction speedup logic.

  Show description for 352f74a
  derekpierre

  committed
  352f74a

  Copy full SHA for 352f74a

• Add tests for constructor parameters and legacy tx speed up functionality.

  derekpierre

  committed
  0be4f52

  Copy full SHA for 0be4f52

• Update logging of gas conditions.

  derekpierre

  committed
  c023dea

  Copy full SHA for c023dea

• Better annotations about what the strategy is doing.

  derekpierre

  committed
  979f3f9

  Copy full SHA for 979f3f9

• Don't modify tx nonce as part of strategy.

  derekpierre

  committed
  9589151

  Copy full SHA for 9589151

• Fix outdated comment about value of warn factor.

  derekpierre

  committed
  b66f5af

  Copy full SHA for b66f5af

• Clean up logging logic since old_tip, old_max_fee may or may not be present in transaction parameters (eip1559 allows one or both).

  derekpierre

  committed
  bf13194

  Copy full SHA for bf13194

• Add tests for eip1559 transaction speedup.

  derekpierre

  committed
  f7bd316

  Copy full SHA for f7bd316

• Rename speed up strategy; while the rate value is fixed the updates are expontential because they build on previous updates.

  derekpierre

  committed
  699d38f

  Copy full SHA for 699d38f

• Use constant instead of "maxPriorityFeePerGas".

  derekpierre

  committed
  3755667

  Copy full SHA for 3755667

• Use constant for minimum required speedup increase percentage.

  derekpierre

  committed
  16c2ed3

  Copy full SHA for 16c2ed3

• Use a max between a low default value and warn factor calc in case timeout is too short and warn threshold becomes too low.

  Show description for 1c67055
  derekpierre

  committed
  1c67055

  Copy full SHA for 1c67055

• Add todo about best way of setting a cap on the speedup strategy.

  derekpierre

  committed
  f8cf36b

  Copy full SHA for f8cf36b

• Use reactor to determine when hook is called instead of repeatedly calling _cycle() on the machine - the latter could hide bugs so don't do it.

  derekpierre

  committed
  1f1fb28

  Copy full SHA for 1f1fb28

• Add TODO to determine whether strategies can be overriden.

  derekpierre

  committed
  abb8555

  Copy full SHA for abb8555

Commits on Mar 5, 2024

• Update logging category for monitor when no longer tracking tx.

  derekpierre

  committed
  5491a6e

  Copy full SHA for 5491a6e

• Use enable/disabling of auto mining for better testing.

  derekpierre

  committed
  2a9c0b5

  Copy full SHA for 2a9c0b5

• Fix nonce logging message for strategies.

  derekpierre

  committed
  436ce64

  Copy full SHA for 436ce64

• Add the ability to update the tracker's active pending tx after a retry.

  derekpierre

  committed
  c7851ae

  Copy full SHA for c7851ae

• Ensure that "from" value in tx params matches/equals signer.

  Show description for 7e647c0
  derekpierre

  committed
  7e647c0

  Copy full SHA for 7e647c0

• Make __fire reusable by both broadcast and strategize - it is now limited to send raw transaction and returning the tx hash.

  Show description for 283ba70
  derekpierre

  committed
  283ba70

  Copy full SHA for 283ba70

• Add tests to ensure that strategies are employed when a tx hasn't already been mined and needs replacing.

  derekpierre

  committed
  bd27cbf

  Copy full SHA for bd27cbf

Commits on Mar 6, 2024

• Add testing for "from" tx parameter handling when a tx is being queued.

  derekpierre

  committed
  25ad0b5

  Copy full SHA for 25ad0b5

• Add test for strategies which do not make updates to parameters.

  derekpierre

  committed
  adac77d

  Copy full SHA for adac77d

• Add testing statements to ensure that the broadcast hook is also called for tx retries.

  Show description for dc6cda3
  derekpierre

  committed
  dc6cda3

  Copy full SHA for dc6cda3

• txhash is not optionally returned from __fire - either it is or an exception was raised.

  derekpierre

  committed
  28f67f4

  Copy full SHA for 28f67f4

• Potential specialized handling of error cases when firing a tx; this can happen during broadcast or retry.

  Show description for a7eff18
  derekpierre

  committed
  a7eff18

  Copy full SHA for a7eff18

• Commonize check for recoverable type of error after calling sendRawTransaction.

  Show description for 9ea695c
  derekpierre

  committed
  9ea695c

  Copy full SHA for 9ea695c

• Insufficient funds is really a special case and its own exception, not a subclass.

  Show description for f42264d
  derekpierre

  committed
  f42264d

  Copy full SHA for f42264d

• Fix firing of hook with only ordered args.

  derekpierre

  committed
  9013c0d

  Copy full SHA for 9013c0d

• Add test for unrecoverable errors encoutered when trying to broadcast a tx.

  derekpierre

  committed
  f5ecc5a

  Copy full SHA for f5ecc5a

Commits on Mar 7, 2024

• Add test for recoverable errors encoutered when trying to broadcast a tx.

  derekpierre

  committed
  4905e07

  Copy full SHA for 4905e07

• Add test for unrecoverable errors encoutered when trying to retry a tx.

  derekpierre

  committed
  d695078

  Copy full SHA for d695078

• Retry failures should be treated differently than broadcast failures. Basically retries only happen after a broadcast has been successful, so we know that the base parameters were correct/fine.

  Show description for e000b64
  derekpierre

  committed
  e000b64

  Copy full SHA for e000b64

• Make methods on TxTracker public instead of protected.

  derekpierre

  committed
  b744a93

  Copy full SHA for b744a93

• Use a counter for tracking number of requeue attempts for failed txs during broadcast.

  derekpierre

  committed
  431462e

  Copy full SHA for 431462e

• Use a counter for tracking number of failed retry attempts when using strategies to retry a tx.

  derekpierre

  committed
  290fd65

  Copy full SHA for 290fd65

• Update existing tests given limits on requeue/retry (redo) attempts.

  derekpierre

  committed
  5c42f80

  Copy full SHA for 5c42f80

• Add test for exceeding retries when encountering a broadcast error.

  derekpierre

  committed
  189b2dd

  Copy full SHA for 189b2dd

• Add additional assertions for the requeue counter in existing tests.

  derekpierre

  committed
  f4670ac

  Copy full SHA for f4670ac

• Existing retry test cleanup.

  derekpierre

  committed
  c370dea

  Copy full SHA for c370dea

• Add test for exceeding retries when encountering retry errors.

  derekpierre

  committed
  f59aa74

  Copy full SHA for f59aa74

• Ensure that retry_failure_counter is cleared for all exit cases fault, success.

  derekpierre

  committed
  86734c3

  Copy full SHA for 86734c3

• Rename constant to _MAX_REDO_ATTEMPTS.

  derekpierre

  committed
  190ed94

  Copy full SHA for 190ed94

• Add TODO.

  derekpierre

  committed
  f820474

  Copy full SHA for f820474

• Track num requeues and num retries directly on FutureTx and PendingTx. This allows for not needing extra logic for clearing out the dictionary used in the original tracking logic.

  Show description for a2ea01c
  derekpierre

  committed
  a2ea01c

  Copy full SHA for a2ea01c