Update siwe library to support did/wildcard URIs in SIWE message string; drop Python 3.8 support
#3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues with dependency resolution.
…flicts can be resolved.
…we library. Update tests accordingly including testing did URIs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v7.4.x #3521 +/- ##
==========================================
- Coverage 84.94% 84.93% -0.02%
==========================================
Files 123 123
Lines 11397 11396 -1
==========================================
- Hits 9681 9679 -2
- Misses 1716 1717 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…sen dependency restrictions.
derekpierre
changed the title
did/wildcard URIs in SIWE message stringdid/wildcard URIs in SIWE message string
derekpierre
changed the title
did/wildcard URIs in SIWE message stringdid/wildcard URIs in SIWE message string; drop Python 3.8 support
derekpierre
requested review from
KPrasch,
cygnusv,
theref,
vzotova,
manumonti and
piotr-roslaniec
KPrasch
approved these changes
Jul 23, 2024
cygnusv
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
siwe-pyused that includes fix for proper URI handlingIssues fixed/closed:
Depends on:
eth-account,eth-utilsandeth-typingdependencies. spruceid/siwe-py#70Related to https://github.com/nucypher/sprints/issues/24
Why it's needed:
siwe v2.4.1 does not properly handle
did/wildcard URIs. This was fixed in siwe 3.0.0 via spruceid/siwe-py#60. However updating to version 3.0.0 or greater introduces some dependency conflicts witheth-ape. We needed spruceid/siwe-py#70 to be merged intosiwe-pyand a fresh release for the conflicts to go away.Notes for reviewers: