Comments couple field in JWT to match with PR in nucypher repo

nucypher · Jan 3, 2025 · 91c4e3a · 91c4e3a
1 parent 5c72c19
commit 91c4e3a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/packages/taco/src/conditions/schemas/jwt.ts b/packages/taco/src/conditions/schemas/jwt.ts
@@ -11,9 +11,10 @@ export const jwtConditionSchema = baseConditionSchema.extend({
   conditionType: z.literal(JWTConditionType).default(JWTConditionType),
   publicKey: z.string().optional(),
   expectedIssuer: z.string().optional(),
-  subject: contextParamSchema.optional(),
-  expirationWindow: z.number().int().nonnegative().optional(),
-  issuedWindow: z.number().int().nonnegative().optional(),
+  // TODO see https://github.com/nucypher/taco-web/pull/604#discussion_r1901746814
+  // subject: contextParamSchema.optional(),
+  // expirationWindow: z.number().int().nonnegative().optional(),
+  // issuedWindow: z.number().int().nonnegative().optional(),
   jwtToken: contextParamSchema.default(JWT_PARAM_DEFAULT),
 });
 

diff --git a/packages/taco/test/conditions/base/jwt.test.ts b/packages/taco/test/conditions/base/jwt.test.ts
@@ -23,15 +23,15 @@ describe('JWTCondition', () => {
     it('rejects an invalid schema', () => {
       const badJWTObj = {
         ...testJWTConditionObj,
-        subject: TEST_CONTRACT_ADDR,
+        jwtToken: TEST_CONTRACT_ADDR,
       };
 
       const result = JWTCondition.validate(jwtConditionSchema, badJWTObj);
 
       expect(result.error).toBeDefined();
       expect(result.data).toBeUndefined();
       expect(result.error?.format()).toMatchObject({
-        subject: {
+        jwtToken: {
           _errors: ['Invalid'],
         },
       });

diff --git a/packages/taco/test/test-utils.ts b/packages/taco/test/test-utils.ts
@@ -269,9 +269,9 @@ export const testJWTConditionObj: JWTConditionProps = {
   conditionType: JWTConditionType,
   publicKey: TEST_ECDSA_PUBLIC_KEY,
   expectedIssuer: '0xacbd',
-  subject: ':userAddress',
-  expirationWindow: 1800,
-  issuedWindow: 86400,
+  // subject: ':userAddress',
+  // expirationWindow: 1800,
+  // issuedWindow: 86400,
   jwtToken: JWT_PARAM_DEFAULT,
 };