Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for conditions #396

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

piotr-roslaniec
Copy link
Contributor

Type of PR:

  • Other

Required reviews:

  • 1

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for taco-nft-demo canceled.

Name Link
🔨 Latest commit aad5371
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/655c8932cb46980008f02329

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for taco-demo canceled.

Name Link
🔨 Latest commit aad5371
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/655c8932b8f19600088338d4

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (202f060) 88.01% compared to head (ea54d99) 88.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files          33       33           
  Lines        2704     2704           
  Branches      232      232           
=======================================
  Hits         2380     2380           
  Misses        293      293           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review November 14, 2023 15:29
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotr-roslaniec piotr-roslaniec merged commit 3fb8b78 into nucypher:main Nov 21, 2023
4 of 5 checks passed
@piotr-roslaniec piotr-roslaniec deleted the add-tests branch November 21, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants