-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for conditions #396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taco-nft-demo canceled.
|
✅ Deploy Preview for taco-demo canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
=======================================
Coverage 88.01% 88.01%
=======================================
Files 33 33
Lines 2704 2704
Branches 232 232
=======================================
Hits 2380 2380
Misses 293 293
Partials 31 31 ☔ View full report in Codecov by Sentry. |
piotr-roslaniec
requested review from
jMyles,
KPrasch,
cygnusv,
theref,
derekpierre and
manumonti
November 15, 2023 11:01
derekpierre
reviewed
Nov 15, 2023
derekpierre
reviewed
Nov 15, 2023
piotr-roslaniec
force-pushed
the
add-tests
branch
from
November 16, 2023 07:05
ff7b07a
to
10231b9
Compare
piotr-roslaniec
force-pushed
the
add-tests
branch
from
November 17, 2023 07:51
10231b9
to
ea54d99
Compare
manumonti
approved these changes
Nov 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
piotr-roslaniec
force-pushed
the
add-tests
branch
from
November 21, 2023 10:40
ea54d99
to
aad5371
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Issues fixed/closed:
Why it's needed:
Notes for reviewers:
lynx
release #379