Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peer & core dependencies config #402

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

piotr-roslaniec
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec commented Nov 17, 2023

Type of PR:

  • Other

Required reviews:

  • 1

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for taco-nft-demo ready!

Name Link
🔨 Latest commit b06aece
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/655c8bc1073cc5000834054c
😎 Deploy Preview https://deploy-preview-402--taco-nft-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for taco-demo ready!

Name Link
🔨 Latest commit b06aece
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/655c8bc1a3423b0008205fc3
😎 Deploy Preview https://deploy-preview-402--taco-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2e3a53) 88.00% compared to head (376b9a6) 88.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files          33       33           
  Lines        2700     2700           
  Branches      232      232           
=======================================
  Hits         2376     2376           
  Misses        293      293           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

'not': CompoundCondition.not,
and: CompoundCondition.and,
or: CompoundCondition.or,
not: CompoundCondition.not,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When was this block changed to using quotes? I remember there was a recent change, in which I commented, with the same diff (i.e., removing the quotes). Is it possible that there's conflicting linting configurations somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's the case, but I wasn't able to reproduce that. I will keep an eye on that. The proper way to format is to use pnpm lint:fix and that should be consistent with the CI check, pnpm ci:lint.

@piotr-roslaniec piotr-roslaniec merged commit 7954602 into nucypher:main Nov 21, 2023
4 of 5 checks passed
@piotr-roslaniec piotr-roslaniec deleted the packages branch November 21, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing peer dependency @nucypher/core
4 participants