-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update peer & core dependencies config #402
Conversation
✅ Deploy Preview for taco-nft-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for taco-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
95b489d
to
f3c47d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
=======================================
Coverage 88.00% 88.00%
=======================================
Files 33 33
Lines 2700 2700
Branches 232 232
=======================================
Hits 2376 2376
Misses 293 293
Partials 31 31 ☔ View full report in Codecov by Sentry. |
'not': CompoundCondition.not, | ||
and: CompoundCondition.and, | ||
or: CompoundCondition.or, | ||
not: CompoundCondition.not, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When was this block changed to using quotes? I remember there was a recent change, in which I commented, with the same diff (i.e., removing the quotes). Is it possible that there's conflicting linting configurations somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's the case, but I wasn't able to reproduce that. I will keep an eye on that. The proper way to format is to use pnpm lint:fix
and that should be consistent with the CI check, pnpm ci:lint
.
f3c47d7
to
376b9a6
Compare
376b9a6
to
b06aece
Compare
Type of PR:
Required reviews:
What this does:
Issues fixed/closed:
@nucypher/core
#401Why it's needed:
Notes for reviewers: