feat: allow authorization token for JsonApiCondition to support endpoints requiring OAuth, JWT authorization
#599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## epic-v0.6.x #599 +/- ##
==============================================
Coverage ? 89.23%
==============================================
Files ? 73
Lines ? 6524
Branches ? 172
==============================================
Hits ? 5822
Misses ? 702
Partials ? 0 ☔ View full report in Codecov by Sentry. |
derekpierre
changed the title
JsonApiCondition to support endpoints requiring OAuth, JWT authenticationJsonApiCondition to support endpoints requiring OAuth, JWT authorization
derekpierre
force-pushed
the
json-auth
branch
from
422a0f9 to
c605c28
Compare
derekpierre
requested review from
KPrasch,
arjunhassard,
cygnusv,
theref,
vzotova and
manumonti
derekpierre
changed the title
JsonApiCondition to support endpoints requiring OAuth, JWT authorizationJsonApiCondition to support endpoints requiring OAuth, JWT authorization
theref
reviewed
Oct 29, 2024
…tion. The value for an authorization token must be a context variable.
There is a difference between checking that an entire string is a context variable, and checking whether a context variable is a substring within a string - make that difference clearer with respect to regexp constants.
derekpierre
force-pushed
the
json-auth
branch
from
c605c28 to
0e25a11
Compare
vzotova
approved these changes
Oct 29, 2024
theref
approved these changes
Oct 30, 2024
cygnusv
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Based over #598 .
Updates the
taco-webcode to allowauthorizationTokento be optionally provided for OAuth/JWT support.Issues fixed/closed:
Notes for reviewers: