Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonRpcCondition #606

Merged
merged 8 commits into from
Jan 6, 2025
Merged

JsonRpcCondition #606

merged 8 commits into from
Jan 6, 2025

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Dec 18, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR. List relevant API
changes (if any), as well as related PRs and issues.

Implements JsonRpcCondition based on nucypher/nucypher#3571.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g.,
if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section
of your PR that requires more attention from reviewers?

@derekpierre derekpierre self-assigned this Dec 18, 2024
@derekpierre derekpierre mentioned this pull request Dec 18, 2024
20 tasks
@derekpierre derekpierre force-pushed the json-rpc branch 2 times, most recently from 23a026e to 02f5cff Compare December 18, 2024 17:59
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (epic-v0.6.x@6baef32). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             epic-v0.6.x     #606   +/-   ##
==============================================
  Coverage               ?   89.19%           
==============================================
  Files                  ?       75           
  Lines                  ?     6610           
  Branches               ?      361           
==============================================
  Hits                   ?     5896           
  Misses                 ?      679           
  Partials               ?       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derekpierre derekpierre changed the title [WIP] JsonRpcCondition JsonRpcCondition Dec 19, 2024
@derekpierre derekpierre marked this pull request as ready for review December 19, 2024 16:13
…perties. The logic is now more general and doesn't require adding special cases every time a new condition is created.
@derekpierre
Copy link
Member Author

@theref theref merged commit c85d30d into nucypher:epic-v0.6.x Jan 6, 2025
4 checks passed
@derekpierre derekpierre mentioned this pull request Jan 7, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants