-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonRpcCondition #606
Merged
Merged
JsonRpcCondition #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekpierre
force-pushed
the
json-rpc
branch
2 times, most recently
from
December 18, 2024 17:59
23a026e
to
02f5cff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## epic-v0.6.x #606 +/- ##
==============================================
Coverage ? 89.19%
==============================================
Files ? 75
Lines ? 6610
Branches ? 361
==============================================
Hits ? 5896
Misses ? 679
Partials ? 35 ☔ View full report in Codecov by Sentry. |
derekpierre
force-pushed
the
json-rpc
branch
from
December 19, 2024 15:07
140539d
to
32d4b9a
Compare
derekpierre
requested review from
KPrasch,
arjunhassard,
cygnusv,
theref,
vzotova and
manumonti
December 19, 2024 16:12
derekpierre
force-pushed
the
json-rpc
branch
from
December 19, 2024 16:28
32d4b9a
to
3c79081
Compare
…perties. The logic is now more general and doesn't require adding special cases every time a new condition is created.
…ed appropriately from conditions.
derekpierre
force-pushed
the
json-rpc
branch
from
December 19, 2024 17:01
3c79081
to
cfd8c73
Compare
vzotova
approved these changes
Dec 19, 2024
cygnusv
approved these changes
Jan 2, 2025
Update tests to validate refinement.
theref
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Implements
JsonRpcCondition
based on nucypher/nucypher#3571.Issues fixed/closed:
Why it's needed:
Notes for reviewers: