Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: moving ud containers logs as default in pods view #2378

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

veds-g
Copy link
Contributor

@veds-g veds-g commented Feb 3, 2025

Fixes: #2377

@veds-g veds-g requested review from whynowy and vigith as code owners February 3, 2025 11:54
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (afc16ac) to head (0ff6b56).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2378      +/-   ##
==========================================
+ Coverage   69.61%   69.65%   +0.04%     
==========================================
  Files         361      361              
  Lines       50040    50040              
==========================================
+ Hits        34833    34855      +22     
+ Misses      14123    14107      -16     
+ Partials     1084     1078       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigith vigith requested a review from adarsh0728 February 3, 2025 14:46
Copy link
Contributor

@yhl25 yhl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@yhl25 yhl25 merged commit 208527d into numaproj:main Feb 3, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display User-Defined Container logs as the default in the Pods View
3 participants