Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Taylor Series #142

Merged
merged 13 commits into from
Oct 23, 2023
Merged

Add Taylor Series #142

merged 13 commits into from
Oct 23, 2023

Conversation

fsxbhyy
Copy link
Collaborator

@fsxbhyy fsxbhyy commented Oct 4, 2023

Add the Taylor Series structure.

@fsxbhyy fsxbhyy added the enhancement New feature or request label Oct 4, 2023
@fsxbhyy fsxbhyy requested review from kunyuan, dcerkoney and houpc October 4, 2023 02:35
@fsxbhyy fsxbhyy self-assigned this Oct 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Attention: 182 lines in your changes are missing coverage. Please review.

Comparison is base (e40c35d) 64.19% compared to head (0ecf012) 64.71%.
Report is 3 commits behind head on computgraph.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           computgraph     #142      +/-   ##
===============================================
+ Coverage        64.19%   64.71%   +0.52%     
===============================================
  Files               56       62       +6     
  Lines             3854     4328     +474     
===============================================
+ Hits              2474     2801     +327     
- Misses            1380     1527     +147     
Files Coverage Δ
src/FeynmanDiagram.jl 75.00% <ø> (ø)
src/TaylorSeries/TaylorSeries.jl 100.00% <100.00%> (ø)
src/computational_graph/ComputationalGraph.jl 100.00% <ø> (ø)
src/computational_graph/abstractgraph.jl 75.60% <ø> (ø)
src/computational_graph/operation.jl 90.21% <100.00%> (+10.02%) ⬆️
src/TaylorSeries/constructors.jl 87.50% <87.50%> (ø)
src/computational_graph/transform.jl 97.28% <93.75%> (-0.75%) ⬇️
src/computational_graph/graph.jl 68.31% <40.00%> (-1.79%) ⬇️
src/backend/static.jl 39.36% <50.00%> (+0.98%) ⬆️
src/TaylorSeries/parameter.jl 62.50% <62.50%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"""
mutable struct TaylorSeries{F,W,N}

A representation of a computational graph, e.g., an expression tree, with type stable node data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the doc string doesn't match with the code

@fsxbhyy fsxbhyy merged commit 9a1cb5f into computgraph Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants