Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocation of DiagramId, Filter, ... to FrontEnds Module. #173

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Relocation of DiagramId, Filter, ... to FrontEnds Module. #173

merged 2 commits into from
Jan 11, 2024

Conversation

houpc
Copy link
Member

@houpc houpc commented Jan 11, 2024

  1. Relocation of DiagramId, Filter, Response, AnalyticalProperty, and TwoBodyChannel to FrontEnds Module.
  2. DiagramId: 1) adds a {P} parameter; 2) Specifies the direction of extK in constructors; 3) Modifies the isequal function for the extT field with Instant types.

@houpc houpc added the refactor refactor the code label Jan 11, 2024
@houpc houpc requested a review from kunyuan January 11, 2024 09:47
@houpc houpc self-assigned this Jan 11, 2024
@houpc houpc merged commit e21e062 into computgraph Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunyuan kunyuan kunyuan approved these changes

Assignees

@houpc houpc

Labels
refactor refactor the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@houpc @kunyuan