[statistics] Fix use of uninitialized variable

numworks · Jan 5, 2021 · d022231 · d022231
1 parent f449db6
commit d022231
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/apps/statistics/histogram_parameter_controller.cpp b/apps/statistics/histogram_parameter_controller.cpp
@@ -26,8 +26,12 @@ HistogramParameterController::HistogramParameterController(Responder * parentRes
 
 void HistogramParameterController::viewWillAppear() {
   // Initialize temporary parameters to the extracted value.
+  /* setParameterAtIndex uses the value of the other parameter, so we need to
+   * manually set the value of the second parameter before the first call. */
+  double parameterAtIndex1 = extractParameterAtIndex(1);
+  m_tempFirstDrawnBarAbscissa = parameterAtIndex1;
   setParameterAtIndex(0, extractParameterAtIndex(0));
-  setParameterAtIndex(1, extractParameterAtIndex(1));
+  setParameterAtIndex(1, parameterAtIndex1);
   FloatParameterController::viewWillAppear();
 }