Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move table to valid markdown in release notes #998

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

SeanKilleen
Copy link
Member

@SeanKilleen SeanKilleen commented Dec 21, 2024

HTML is not valid in markdown and we need to avoid it where possible.

Similarly, using tables for purely visual layout is to be avoided, especially when there are not clear columns. It cuts things off on mobile and can be detrimental to the accessibility experience.

Copy link

github-actions bot commented Dec 21, 2024

@SeanKilleen SeanKilleen marked this pull request as ready for review December 21, 2024 16:08
@SeanKilleen
Copy link
Member Author

@OsirisTerje I made the change the the table here, just FYI so that you don't have to. 👍

@SeanKilleen SeanKilleen merged commit 0c35d40 into master Dec 21, 2024
7 checks passed
@SeanKilleen SeanKilleen deleted the SeanKilleen-patch-8 branch December 21, 2024 16:39
github-actions bot pushed a commit that referenced this pull request Dec 21, 2024
* Move table to valid markdown in release notes

* More table conversion 0c35d40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant