Add greater functionaility to the app #436
Open
+581
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A "mark and unmark" feature would help users keep track of tasks better. Creating a Task class helps to better abstract the project and assists in the creation of such a feature as mentioned above. Let's create a Task class with the functionality required to implement task completion tracking.
Unique categories of tasks would allow the users to customise their lists and allow for greater freedom. Let's add different categories of Tasks, namely Todos, Events and Deadlines for the user to segregate their workflow.
Let's make the UI testing more robust by testing for more commands.
The user may provide incorrect input which the program may be unable to process. Let's add error handling for these edge cases.
Users may need to to delete the tasks in the list to reduce clutter. Let's add a delete function.
Luoq1-Xu
reviewed
Feb 3, 2025
src/main/java/main/Tyler.java
Outdated
|
|
||
| Scanner sc = new Scanner(System.in); | ||
| ArrayList<Task> tasks = new ArrayList<>(); | ||
| int i = 0; |
There was a problem hiding this comment.
This variable seems a little out of place. Perhaps a more informative variable name would be good here.
src/main/java/main/Tyler.java
Outdated
Comment on lines
26
to
27
| System.out.print(separator + greeting | ||
| + separator); |
There was a problem hiding this comment.
Perhaps this can be condensed into a single line? It does not seem very long.
src/main/java/task/Task.java
Outdated
Comment on lines
61
to
70
| /** | ||
| * Adds task to array passed in as argument at specified index. | ||
| * Returns the index of the next position to add a task. | ||
| * | ||
| * @param tasks Array to which task must be added. | ||
| * @param index Position of task to be added. | ||
| * @param task Task to be added. | ||
| * @return Next task addition index. | ||
| * @throws IllegalArgumentException If task description is blank. | ||
| */ |
| @@ -0,0 +1,21 @@ | |||
| package task; | |||
|
|
|||
| public class Deadline extends Task { | |||
There was a problem hiding this comment.
Perhaps it would be good to have header comments for each class as well? To give the reader a quick introduction to what the class is about.
The user may want their tasklist to persist between sessions. Let's add a storage function to the bot.
| Files.createFile(tylerPath); | ||
| } | ||
|
|
||
| List<String> stored = Files.readAllLines(tylerPath); |
There was a problem hiding this comment.
Could this be more specific on what is being stored?
The user would benefits from being able to enter dates in a computer-parsable format, as it would allow for increased tracking capabilities. Let's add date and time functionality to the bot, as well as a command that lists out tasks with dates matching with the date provided by the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add many more features to the app, including adding and removing tasks freely and introducing different types of tasks.