[Timothy Tay] iP #441
Open
[Timothy Tay] iP #441
+1,738
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
soonami69
reviewed
Feb 4, 2025
| /** | ||
| * The AddDeadlineCommand class represents the command to add a deadline task. | ||
| */ | ||
| private static final String horizontalLine = "-------------------------------------------" + |
There was a problem hiding this comment.
I like how you broke this long line so as to not make the line too long!
src/main/java/AddToDoCommand.java
Outdated
| @Override | ||
| public void execute(Ui ui, Storage storage) { | ||
| ToDoTask newTask = new ToDoTask(this.taskDescription); | ||
| String added = storage.addToList(newTask); |
There was a problem hiding this comment.
Perhaps a more descriptive name instead of added would be better?
src/main/java/Parser.java
Outdated
| /** | ||
| * The Parser class takes in user input and interprets it to perform the necessary actions. | ||
| */ | ||
| private static final String horizontalLine = "--------------------------------------------------------------------------------\n"; |
There was a problem hiding this comment.
I think this line may be too long. Consider breaking it into two?
src/main/java/Parser.java
Outdated
| return commands; | ||
| case "mark": | ||
| try { | ||
| String[] mark = str.split("mark ", 2); |
There was a problem hiding this comment.
Perhaps a more intuitive variable name here? I don't quite understand what mark's purpose is based on its name.
src/main/java/Parser.java
Outdated
| LocalDate to = LocalDate.parse(timeline[1].trim(), DateTimeFormatter.ofPattern("MMM dd yyyy")); | ||
| commands.add(new AddEventCommand( | ||
| CommandType.EVENT, remainingParts[0].trim(), from, to)); | ||
| if (isDone) { |
There was a problem hiding this comment.
I like how you named the boolean variables intuitively!
src/main/java/Ui.java
Outdated
| /** | ||
| * Prints the farewell message of the chatbot. | ||
| */ | ||
| public static void bye() { |
There was a problem hiding this comment.
I think this should be a verb. Maybe sayGoodbye?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.