Wang Haitao iP #449
Wang Haitao iP #449
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
1. Better modularisation of the code 2. added delete function 3. fixed output format problem
src/out/production/ip/Deadline.class
Outdated
There was a problem hiding this comment.
You might want to git ignore the .class
src/main/java/Task.java
Outdated
There was a problem hiding this comment.
Great naming conventions here for the formats!
src/main/java/Duke.java
Outdated
| } else { | ||
| try { | ||
| switch(parts[0]) { | ||
| case "deadline": |
There was a problem hiding this comment.
Based on the coding standards, cases have no indentations (same indent as switch)
src/main/java/TaskList.java
Outdated
| @@ -0,0 +1,68 @@ | |||
| import utils.Utils; | |||
|
|
|||
| import java.util.ArrayList; | |||
There was a problem hiding this comment.
Might be better to put ArrayList before custom imports like utils, as that caused me to violate the checkstyle
However the coding standards dont enforce this to that degree so this is really up to your personal preference
src/main/java/Duke.java
Outdated
| @@ -3,7 +3,7 @@ | |||
| import java.util.Optional; | |||
There was a problem hiding this comment.
I really like how you're using typing in order to annotate your classes and allow for empties!
src/main/java/TaskList.java
Outdated
| public void add_item(Task item) { | ||
| this.list.add(item); | ||
| System.out.println("Got it. I've added this task:"); | ||
| printTask(item); | ||
| Utils.output("Now you have " + this.list.size() + " tasks in the list."); | ||
| saveToFile(); | ||
| } | ||
|
|
||
| public void delete_item_by_index(int index) throws DukeException { | ||
| if (index < 1 || index > list.size()) { | ||
| throw new DukeException("Invalid task number! Please provide a number between 1 and " + list.size()); | ||
| } | ||
| Task removedTask = list.remove(index - 1); | ||
| System.out.println("Noted. I've removed this task:"); | ||
| printTask(removedTask); | ||
| Utils.output("Now you have " + this.list.size() + " tasks in the list."); | ||
| saveToFile(); | ||
|
|
||
| } | ||
|
|
||
| public void mark_done_by_index(int idx) { | ||
| if (idx > this.list.size()){ | ||
| Utils.output("Task number does not exist!"); | ||
| }else{ | ||
| System.out.println("Nice! I've marked this task as done:"); | ||
| Task item = this.list.get(idx - 1); | ||
| item.markDone(); | ||
| printTask(item); | ||
| saveToFile(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please follow the naming convention for class methods.
Suggested:
addItem(args)
deleteItem(args)
markDone(args)
No description provided.