Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove api module dependency from common module #1019

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

jimmidyson
Copy link
Member

Move CAPA and CAPX specific test requests to root module. This allows
other projects to use the common module without also pulling in the
CAREN api module.

Also remove some unused code.

Move CAPA and CAPX specific test requests to root module. This allows
other projects to use the common module without also pulling in the
CAREN api module.

Also remove some unused code.
@jimmidyson jimmidyson force-pushed the jimmi/remove-apis-dep-from-common branch from c9cd2e9 to b92d2f4 Compare January 22, 2025 17:16
Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Copy link
Contributor

@supershal supershal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jimmidyson jimmidyson merged commit 38a5fab into main Jan 23, 2025
22 checks passed
@jimmidyson jimmidyson deleted the jimmi/remove-apis-dep-from-common branch January 23, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants