feat(stacked-PR): create cluster with custom helm chart config #1023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
default-helm-addons-config
that is shipped with CAREN.default-helm-addons-config
configmapHow Has This Been Tested?:
[X] unit test for addon webhook
[]unit test for HelmChartGetter (will add new commit)
[]e2e tests with custom configmap (Will file stacked PR)
[X] manual test on Nutanix Cluster
Special notes for your reviewer:
The discussion for the API is still going on at #1015
While main logic would remain same, if any changes proposed in the API, I will update this PR with the implementation.
Open question:
Should we set owner reference in the referenced configmap?