NXDRIVE-2889: Display system notification for document review #4878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NXDRIVE-2889-Display-notification-for-document-review
…ew' of https://github.com/nuxeo/nuxeo-drive into wip-NXDRIVE-2889-Display-notification-for-document-review
…NXDRIVE-2889-Display-notification-for-document-review
…NXDRIVE-2889-Display-notification-for-document-review
…NXDRIVE-2889-Display-notification-for-document-review
* NXDRIVE-2899: Display new workflow feature on Features tab
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Comment on lines
+22
to
+31
| """Fetch document details""" | ||
| first_task = tasks_list[0] | ||
| doc_id = first_task.targetDocumentIds[0]["id"] | ||
| task_id = first_task.id | ||
|
|
||
| response = self.remote.documents.get(doc_id) | ||
| if response: | ||
| engine.send_task_notification(task_id, response.path) | ||
| else: | ||
| log.error("Failed to fetch document details.") |
There was a problem hiding this comment.
issue (code-quality): We've found these issues:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Move assignments closer to their usage (
move-assign)
| """Get Tasks for document review""" | ||
| try: | ||
| options = {"userId": self.remote.user_id} | ||
| tasks = self.remote.tasks.get(options) |
There was a problem hiding this comment.
issue (code-quality): Use named expression to simplify assignment and conditional (use-named-expression)
swetayadav1
merged commit 74f5e9b
into
wip-NXDRIVE-2873-Handle-workflow-in-drive
18 of 20 checks passed
swetayadav1
deleted the
wip-NXDRIVE-2889-Display-system-notification-for-document-review
branch
gitofanindya
pushed a commit
that referenced
this pull request
Jul 25, 2024
* NXDRIVE-2889: Display system notification for document review (#4878) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: mr-shekhar <[email protected]> Co-authored-by: swetayadav1 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: poojadaine <[email protected]> Co-authored-by: Sweta Yadav <[email protected]> Co-authored-by: swetayadav1 <[email protected]> Co-authored-by: GitHub-CI action (Release) <[email protected]> Co-authored-by: Pooja Ramkrishna Daine <[email protected]> Co-authored-by: Filip <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <[email protected]> Co-authored-by: Sushil Chaudhary <[email protected]> Co-authored-by: sushildeep <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NXDRIVE-2889: Display system notification for document review