Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use node:path to resolve dist directory #1054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scottbedard
Copy link

@scottbedard scottbedard commented Jan 1, 2025

πŸ”— Linked issue

#1038
#1050

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It appears that 56122b7 caused a regression with 3.15 that can produce the following error. I suspect this is environment-specific. If it were widespread, I'd expect more people to be talking about it.

TypeError: The URL must be of scheme file
 ❯ ../node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected][email protected]_magicast@_qhcyoib43mexeh3yv2rdveqtry/node_modules/@nuxt/test-utils/dirs.js:4:17

Making this change directly inside node_modules works for me, but @danielroe perhaps you can provide more context. If our goal is to simply resolve the dist directory, using node:path could be a safer way to do it.

@scottbedard scottbedard requested a review from danielroe as a code owner January 1, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant