-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts to automate CLI packager and runner #20
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
257910a
to
f46d595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good addition to Holoscan CLI. Added a few comments below.
As I understand it, the new order of dependencies is:
Holoscan SDK <- Holoscan CLI <- HoloHub <- Holoscan CLI testing
Signed-off-by: Victor Chang <[email protected]>
Thanks for the review @tbirdso. There are two paths:
|
Co-authored-by: Tom Birdsong <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and a couple nits mentioned.
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
This PR adds the automation test scripts and instructions to test Holoscan/Holohub applications: