Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts to automate CLI packager and runner #20

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

mocsharp
Copy link
Collaborator

This PR adds the automation test scripts and instructions to test Holoscan/Holohub applications:

  • README with instruction on how to use and how to add new applications
  • script to check pre-requisites
  • script to package and run the specified application
  • preconfigured applications
    • Holoscan: Hello World (Python)
    • Holoscan: Video Replayer (C++ and Python)
    • Holohub: Endoscopy Tool Tracking (C++ and Python)
    • Holohub: Object Detection Torch (C++)

@mocsharp mocsharp self-assigned this Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@mocsharp mocsharp changed the base branch from main to release/2.9.0 January 23, 2025 22:54
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Copy link
Collaborator

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good addition to Holoscan CLI. Added a few comments below.

As I understand it, the new order of dependencies is:
Holoscan SDK <- Holoscan CLI <- HoloHub <- Holoscan CLI testing

tests/automation/test.sh Outdated Show resolved Hide resolved
tests/automation/test.sh Outdated Show resolved Hide resolved
tests/automation/test.sh Show resolved Hide resolved
tests/automation/test.sh Show resolved Hide resolved
tests/automation/test.sh Outdated Show resolved Hide resolved
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
Copy link
Collaborator Author

mocsharp commented Jan 24, 2025

This looks like a good addition to Holoscan CLI. Added a few comments below.

As I understand it, the new order of dependencies is: Holoscan SDK <- Holoscan CLI <- HoloHub <- Holoscan CLI testing

Thanks for the review @tbirdso.

There are two paths:

  1. Holoscan SDK <- Holoscan CLI <- Holoscan CLI testing
  2. Holoscan SDK <- Holoscan CLI <- HoloHub <- Holoscan CLI testing

@mocsharp mocsharp requested a review from tbirdso January 24, 2025 16:36
tests/automation/test.sh Outdated Show resolved Hide resolved
Signed-off-by: Victor Chang <[email protected]>
Copy link
Collaborator

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/automation/check.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@MMelQin MMelQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and a couple nits mentioned.

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp merged commit 5dac640 into release/2.9.0 Jan 24, 2025
@mocsharp mocsharp deleted the vchang/app-testing branch January 24, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants