[Tests] nvm exec/nvm run: add --silent tests
#1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Oct 11, 2016
test/slow/nvm run/Running "nvm run --silent" should work
Outdated
Show resolved
Hide resolved
ljharb
added
testing
|
Thanks!! |
jumbosushi
force-pushed
the
add-silent-flag-tests
branch
4 times, most recently
from
d11bc3f to
120f7b4
Compare
|
Hmm do you know why it's still failing? The output and expected output should be matching now 🤔 |
ljharb
reviewed
Oct 12, 2016
test/slow/nvm run/Running "nvm run --silent" should work
Outdated
Show resolved
Hide resolved
test/slow/nvm run/Running "nvm run --silent" should work
Outdated
Show resolved
Hide resolved
jumbosushi
force-pushed
the
add-silent-flag-tests
branch
2 times, most recently
from
3538de3 to
eaa8148
Compare
|
@jumbosushi are you still interested in completing this PR? |
ljharb
force-pushed
the
add-silent-flag-tests
branch
from
eaa8148 to
c4fd0d1
Compare
ljharb
changed the title
nvm exec/nvm run: add --silent tests
ljharb
force-pushed
the
add-silent-flag-tests
branch
from
c4fd0d1 to
639aaf9
Compare
ljharb
approved these changes
Sep 29, 2021
|
@jumbosushi i've rebased this, but the tests are failing. |
ljharb
force-pushed
the
master
branch
2 times, most recently
from
c6cfc3a to
c20db2a
Compare
ljharb
force-pushed
the
add-silent-flag-tests
branch
2 times, most recently
from
13ae700 to
2cba2f7
Compare
Co-authored-by: Atsushi Yamamoto <[email protected]> Co-authored-by: Jordan Harband <[email protected]>
ljharb
force-pushed
the
add-silent-flag-tests
branch
4 times, most recently
from
93771a7 to
9f520c9
Compare
|
Turns out that the expected output in the 2nd case was incorrect, and the 1st case wasn't testing the full output. That's now been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @ljharb on issue #846, this pr adds tests for --silent flag for "run" and "exec" commands
The tests for "exec" seems to exist already but in a different naming convention, so I renamed to match other tests