Move the bench configuration to a file #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sctb512
force-pushed
the
add-bench-config-file
branch
from
fb8ca72 to
93dd4b7
Compare
Signed-off-by: Bin Tang <[email protected]>
Signed-off-by: Bin Tang <[email protected]>
This file is dumped from hello.py Signed-off-by: Bin Tang <[email protected]>
Signed-off-by: Bin Tang <[email protected]>
sctb512
force-pushed
the
add-bench-config-file
branch
2 times, most recently
from
50acd6d to
f9fdefb
Compare
sctb512
force-pushed
the
add-bench-config-file
branch
from
9512327 to
b8a56eb
Compare
Signed-off-by: Bin Tang <[email protected]>
sctb512
force-pushed
the
add-bench-config-file
branch
from
b8a56eb to
2a2e380
Compare
Signed-off-by: Bin Tang <[email protected]>
sctb512
force-pushed
the
add-bench-config-file
branch
from
677ae05 to
5b80bcc
Compare
Signed-off-by: Bin Tang <[email protected]>
sctb512
force-pushed
the
add-bench-config-file
branch
from
5b80bcc to
e966bf9
Compare
Signed-off-by: Bin Tang <[email protected]>
Signed-off-by: Bin Tang <[email protected]>
Signed-off-by: Bin Tang <[email protected]>
Signed-off-by: Bin Tang <[email protected]>
Signed-off-by: Bin Tang <[email protected]>
Signed-off-by: Bin Tang <[email protected]>
Signed-off-by: Bin Tang <[email protected]>
Signed-off-by: Bin Tang <[email protected]>
Signed-off-by: Bin Tang <[email protected]>
|
This is a large PR that is hard to review... |
I am sorry. I will divide this PR into several smaller PRs. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to move the bench configuration from
hello.pyto a file.It has two advantages:
crictldriver in k8s environment.Also, generate images for testing.
The generated images contain different IO patterns: