Add CHANGELOG for 1.2.0-rc3 (Azure#904)

* Add changelog for 1.2.0-rc3

* address comment and change version to 1.2.0-rc3

* minor change

* add known issue for shared feature

CHANGELOG/CHANGELOG-1.2.md

@@ -1,10 +1,35 @@
-- [v1.2.0-rc2](#v120-rc2)
+- [v1.2.0-rc3](#v120-rc3)
   - [Important Note](#important-note)
   - [Fixes](#fixes)
+  - [Known Issues](#known-issues)
+- [v1.2.0-rc2](#v120-rc2)
+  - [Important Note](#important-note-1)
+  - [Fixes](#fixes-1)
+  - [Known Issues](#known-issues-1)
 - [v1.2.0-rc1](#v120-rc1)
   - [Features](#features)
-  - [Fixes](#fixes-1)
-  - [Known Issues](#known-issues)
+  - [Fixes](#fixes-2)
+  - [Known Issues](#known-issues-2)
+- [How to try](#how-to-try)
+
+# v1.2.0-rc3
+
+#### Important Note
+
+In this release, AGIC will use the new `hostnames` property in HTTP Listener in Application Gateway instead of `hostname`. With this property, We will be able to expose support for Wild Card hostnames with characters like * and ? allowed to match characters.  
+We are working on bringing Azure Portal support for the new property soon. Until those changes arrive, Users will not be able to view the hostname in the listener section on Portal.
+
+## Fixes:
+* [#867](https://github.com/Azure/application-gateway-kubernetes-ingress/issues/867) Set UnhealthyThreshold on Application Gateway to 20 when readiness/liveness probe has UnhealthyThreshold > 20
+* [#876](https://github.com/Azure/application-gateway-kubernetes-ingress/issues/876) Allow using shared feature in both helm 2 and helm 3
+* [#887](https://github.com/Azure/application-gateway-kubernetes-ingress/issues/887) Update shared feature code to use new listener's hostnames during prohibited list filtering
+* [#890](https://github.com/Azure/application-gateway-kubernetes-ingress/issues/890) Correct scheme contruction for k8s event recorder
+
+## Known Issues:
+* When upgrading an existing helm release, you will see **conflict** when helm tries to update the deployment object.
+  ```bash
+  Error: UPGRADE FAILED: rendered manifests contain a new resource that already exists. Unable to continue with update: existing resource conflict: namespace: default, name: <release-name>, existing_kind: apps/v1, Kind=Deployment, new_kind: apps/v1, Kind=Deployment
+  ```
 
 # v1.2.0-rc2
 
@@ -22,6 +47,13 @@ We are working on bringing Azure Portal support for the new property soon. Until
 * Switch from `hostname` to `hostnames` property in HTTP Listener on Application Gateway.
 * helm: remove replica count setting from supported helm values. This will be added back when AGIC will recieve support for leader election.
 
+## Known Issues:
+* This release has known issues related to enabling `shared` feature with helm. This has been addressed in 1.2.0-rc3.
+* When upgrading an existing helm release, you will see **conflict** when helm tries to update the deployment object.
+  ```bash
+  Error: UPGRADE FAILED: rendered manifests contain a new resource that already exists. Unable to continue with update: existing resource conflict: namespace: default, name: <release-name>, existing_kind: apps/v1, Kind=Deployment, new_kind: apps/v1, Kind=Deployment
+  ```
+
 # v1.2.0-rc1
 
 ## Features:
@@ -39,28 +71,30 @@ We are working on bringing Azure Portal support for the new property soon. Until
 * [#686](https://github.com/Azure/application-gateway-kubernetes-ingress/issues/686): Skip updating the gateway when in non-operational state
 
 ## Known Issues:
-* Issues with installation of ProhibitedTarget CRD using Helm 3. Helm 3 has done away with `crd-install` hooks and requires CRDs to moved to a separate `crd` folder.
+* This release has known issues related to enabling `shared` feature with helm. This has been addressed in 1.2.0-rc3.
 * When upgrading an existing helm release, you will see **conflict** when helm tries to update the deployment object.
   ```bash
   Error: UPGRADE FAILED: rendered manifests contain a new resource that already exists. Unable to continue with update: existing resource conflict: namespace: default, name: <release-name>, existing_kind: apps/v1, Kind=Deployment, new_kind: apps/v1, Kind=Deployment
   ```
 
 ## How to try:
 ```bash
-# use --version 1.2.0-rc2 when installing/upgrading using helm
+# use --version 1.2.0-rc3 when installing/upgrading using helm
+helm repo update
 helm install \
   <release-name> \
   -f helm-config.yaml \
   application-gateway-kubernetes-ingress/ingress-azure \
-  --version 1.2.0-rc2
+  --version 1.2.0-rc3
 
 # or 
 
 # https://github.com/Azure/application-gateway-kubernetes-ingress/blob/master/docs/how-tos/helm-upgrade.md
 # --reuse-values   when upgrading, reuse the last release's values and merge in any overrides from the command line via --set and -f. If '--reset-values' is specified, this is ignored
+helm repo update
 helm upgrade \
   <release-name> \
   application-gateway-kubernetes-ingress/ingress-azure \
   --reuse-values \
-  --version 1.2.0-rc2
+  --version 1.2.0-rc3
 ```

docs/features/agic-reconcile.md

@@ -15,9 +15,9 @@ Acceptable values are between 30 and 300.
 Configure from helm install command(first time install) and helm upgrade command, helm version is v3
 ```bash
 # helm fresh install
-helm intall <releaseName> -f helm-config.yaml application-gateway-kubernetes-ingress/ingress-azure --version 1.2.0-rc1 --set reconcilePeriodSeconds=30 
+helm intall <releaseName> -f helm-config.yaml application-gateway-kubernetes-ingress/ingress-azure --version 1.2.0-rc3 --set reconcilePeriodSeconds=30 
 
 # help upgrade
 # --reuse-values, when upgrading, reuse the last release's values and merge in any overrides from the command line via --set and -f.
-helm upgrade <releaseName> application-gateway-kubernetes-ingress/ingress-azure --reuse-values --version 1.2.0-rc1 --set reconcilePeriodSeconds=30
+helm upgrade <releaseName> application-gateway-kubernetes-ingress/ingress-azure --reuse-values --version 1.2.0-rc3 --set reconcilePeriodSeconds=30
 ```

docs/features/appgw-ssl-certificate.md

@@ -7,9 +7,9 @@ This documents assumes you already have the following Azure tools and resources
 
 Please use [Greenfeild Deployment](https://github.com/Azure/application-gateway-kubernetes-ingress/blob/master/docs/setup/install-new.md) to install nonexistents.
 
-To use the new feature, make sure the AGIC version is at least at 1.2.0-rc1
+To use the new feature, make sure the AGIC version is at least at 1.2.0-rc3
 ```bash
-helm install application-gateway-kubernetes-ingress/ingress-azure -f helm-config.yaml --version 1.2.0-rc1 --generate-name
+helm install application-gateway-kubernetes-ingress/ingress-azure -f helm-config.yaml --version 1.2.0-rc3 --generate-name
 ```
 
 ## Create a certificate and configure the certificate to AppGw

docs/setup/install-existing.md

@@ -153,7 +153,7 @@ You can use [Cloud Shell](https://shell.azure.com/) to install the AGIC Helm pac
       --version 1.0.0
     ```
 
-    >Note: Use at least version 1.2.0-rc1, e.g. `--version 1.2.0-rc1`, when installing on k8s version >= 1.16
+    >Note: Use at least version 1.2.0-rc3, e.g. `--version 1.2.0-rc3`, when installing on k8s version >= 1.16
 
     Alternatively you can combine the `helm-config.yaml` and the Helm command in one step:
     ```bash
@@ -173,7 +173,7 @@ You can use [Cloud Shell](https://shell.azure.com/) to install the AGIC Helm pac
          --version 1.0.0
     ```
 
-    >Note: Use at least version 1.2.0-rc1, e.g. `--version 1.2.0-rc1`, when installing on k8s version >= 1.16
+    >Note: Use at least version 1.2.0-rc3, e.g. `--version 1.2.0-rc3`, when installing on k8s version >= 1.16
 
 1. Check the log of the newly created pod to verify if it started properly
 

docs/setup/install-new-windows-cluster.md

@@ -290,7 +290,7 @@ Values:
       --version 1.0.0
     ```
 
-    >Note: Use at least version 1.2.0-rc1, e.g. `--version 1.2.0-rc1`, when installing on k8s version >= 1.16
+    >Note: Use at least version 1.2.0-rc3, e.g. `--version 1.2.0-rc3`, when installing on k8s version >= 1.16
 
 ### Install a Sample App
 Now that we have App Gateway, AKS, and AGIC installed we can install a sample app

docs/setup/install-new.md

@@ -233,7 +233,7 @@ Values:
       --version 1.0.0
     ```
 
-    >Note: Use at least version 1.2.0-rc1, e.g. `--version 1.2.0-rc1`, when installing on k8s version >= 1.16
+    >Note: Use at least version 1.2.0-rc3, e.g. `--version 1.2.0-rc3`, when installing on k8s version >= 1.16
 
 ### Install a Sample App
 Now that we have App Gateway, AKS, and AGIC installed we can install a sample app