Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mutate the ciphertext in decryption #1981

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maple3142
Copy link

Fix #1980

Just a one line change to avoid mutating the input ciphertext.

@maple3142 maple3142 requested review from a team as code owners January 24, 2025 07:47
Copy link
Member

@Geometer1729 Geometer1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Shigoto-dev19 Shigoto-dev19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

@maple3142
Copy link
Author

Found a bug causing decryption error due to the code after is expecting cipherText array to not contain the auth tag, so pushed a new commit to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encryption.decrypt should not mutate the ciphertext
4 participants