Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping for query sets #93

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Add mapping for query sets #93

merged 4 commits into from
Feb 5, 2025

Conversation

jzonthemtn
Copy link
Collaborator

@jzonthemtn jzonthemtn commented Feb 4, 2025

Adds mapping for query set.

@jzonthemtn
Copy link
Collaborator Author

This gives a mapping that looks like:

{
  "search_quality_eval_query_sets": {
    "mappings": {
      "properties": {
        "datetime": {
          "type": "date",
          "format": "strict_date_time"
        },
        "description": {
          "type": "text"
        },
        "id": {
          "type": "keyword"
        },
        "name": {
          "type": "keyword"
        },
        "query_set_queries": {
                      <--  The query set objects will be in here
        },
        "sampling": {
          "type": "keyword"
        },
        "timestamp": {
          "type": "date"
        }
      }
    }
  }
}

Copy link
Collaborator

@wrigleyDan wrigleyDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes themselves look fine. However, the behavior described in #89 is not resolved by this.

I deleted the search_quality_eval_query_sets index and ran ./create-query-set.sh with the following configuration:

{
  "sampler": "all",
  "name": "",
  "description": "",
  "sampling": "",
  "querySetSize": 250
}

It works with a querySetSize of 5, so I'm thinking that a specific query or queries with specific characteristics cause trouble.

Maybe an empty query is causing trouble? I think an empty query occurs in Chorus when "entering the shop" at localhost:3000.

@jzonthemtn
Copy link
Collaborator Author

The code changes themselves look fine. However, the behavior described in #89 is not resolved by this.

I deleted the search_quality_eval_query_sets index and ran ./create-query-set.sh with the following configuration:

{
  "sampler": "all",
  "name": "",
  "description": "",
  "sampling": "",
  "querySetSize": 250
}

It works with a querySetSize of 5, so I'm thinking that a specific query or queries with specific characteristics cause trouble.

Maybe an empty query is causing trouble? I think an empty query occurs in Chorus when "entering the shop" at localhost:3000.

Got it. I'll leave #89 open and check it out.

@jzonthemtn jzonthemtn merged commit 9989d2f into main Feb 5, 2025
6 checks passed
@jzonthemtn jzonthemtn deleted the 89-query-set-mapping branch February 5, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants