Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize check of the third party RPMs #1327

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pirat89
Copy link
Member

@pirat89 pirat89 commented Jan 10, 2025

This is initial draft to generalize current check of installed third party RPMs that are not part of the installed system distribution.

Original actor has been written only for RHEL systems and expected that the only vendor as such is Red Hat. However, in case of other distributions it's not true. So such a report could be confusing for users and could set wrong expectations.

List of changes:

  • Rename and move redhatsignedrpmcheck actor to <NEW_NAME>
  • Update docstrings
  • Update the report, respecting name of the installed system
  • ...

Draft note: This is an initial draft I made when I crossed this code. Just sharing so someone else do not have to start from zero. It's still just a total draft however.

jira: OAMG-12489

TODO:

  • respecting name of the installed system in the report
  • rename currently consumed leapp message - as the name is misleading - it contains more than just "unsigned" rpms
  • update the title (keep it distro agnostic?)
  • pick the name of the new actor - current one is a draft but i do not like so much.. maybe distrorpmcheck?
  • update tests

Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89
Copy link
Member Author

pirat89 commented Jan 10, 2025

Note this PR is not going to be part of the upcoming release and I do not plan to even work on it in upcoming weeks.

This is initial draft to generalize current check of installed
third party RPMs that are not part of the installed system
distribution.

Original actor has been written only for RHEL systems and expected
that the only vendor as such is Red Hat. However, in case of other
distributions it's not true. So such a report could be confusing for
users and could set wrong expectations.

List of changes:
 * Rename and move redhatsignedrpmcheck actor to <NEW_NAME>
 * Update docstrings
 * Update the report, respecting name of the installed system
 * ...
@pirat89 pirat89 force-pushed the unsigned-rpms-generalisation branch from 0f7f735 to 1fa8d24 Compare January 12, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant