Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SCL conditions from specfile #143

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

r0x0d
Copy link
Member

@r0x0d r0x0d commented Jun 24, 2024

Since we are building with a new buildroot that contains go 1.21, we don't require the scl workarounds anymore. We can just use plain golang in the BuildRequires and the normal make build.

Since we are building with a new buildroot that contains go 1.21, we
don't require the scl workarounds anymore. We can just use plain golang
in the BuildRequires and the normal make build.
@r0x0d r0x0d requested review from andywaltlova and hosekadam June 24, 2024 13:15
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.90%. Comparing base (201200e) to head (972a453).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   65.90%   65.90%           
=======================================
  Files           5        5           
  Lines         264      264           
=======================================
  Hits          174      174           
  Misses         68       68           
  Partials       22       22           
Flag Coverage Δ
go-1.20 65.90% <ø> (ø)
go-1.21 65.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d r0x0d merged commit a2432dd into oamg:main Jun 24, 2024
6 checks passed
@r0x0d r0x0d deleted the fix-specfile-build branch June 24, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants