Stojanovic/fe 237 support moving record from one community to another UI #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirekys
reviewed
Jan 30, 2025
...ies/ui/communities_components/semantic-ui/templates/custom_fields/TargetCommunitySelector.js
Outdated
Show resolved
Hide resolved
mirekys
reviewed
Jan 30, 2025
...ies/ui/communities_components/semantic-ui/templates/custom_fields/TargetCommunitySelector.js
Outdated
Show resolved
Hide resolved
mirekys
reviewed
Jan 30, 2025
...ies/ui/communities_components/semantic-ui/templates/custom_fields/SelectedTargetCommunity.js
Outdated
Show resolved
Hide resolved
mirekys
reviewed
Jan 30, 2025
.../ui/communities_components/semantic-ui/templates/custom_fields/SecondaryCommunitySelector.js
Show resolved
Hide resolved
mirekys
reviewed
Jan 30, 2025
...ies/ui/communities_components/semantic-ui/templates/custom_fields/SelectedTargetCommunity.js
Show resolved
Hide resolved
mirekys
reviewed
Jan 30, 2025
mirekys
reviewed
Jan 30, 2025
| msgstr "Sekundární komunita:" | ||
|
|
||
| #: /home/dusanst/Projects/oarepo-communities/oarepo_communities/requests/submission_secondary.py:94 | ||
| msgid "Initiate record secondary community submission" |
There was a problem hiding this comment.
Same issue as above, shorter text would be nicer:
Add to secondary community / Přidat do sekundarní komunity
Ducica
force-pushed
the
stojanovic/fe-237-support-moving-record-from-one-community-to-another-ui
branch
from
5d00438 to
761e6d4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would ask please for review @mesemus for python part and @mirekys for FE part. The changes depend on oarepo/oarepo-ui#264 there is also another PR in oarepo requests, there we need to fix the failing tests. Generally this PR is not dependent on the one in oarepo requests, except in regards to those error handlers, that are now provided in setup.cfg, which I am not 100% sure I understood correctly. Thanks a lot