fixes per comments

oarepo · Mar 1, 2024 · bac143c · bac143c
1 parent ab73f5d
commit bac143c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/...eme/assets/semantic-ui/js/oarepo_ui/forms/components/EDTFDatePickerField/InputElement.jsx b/...eme/assets/semantic-ui/js/oarepo_ui/forms/components/EDTFDatePickerField/InputElement.jsx
@@ -19,12 +19,10 @@ export const InputElement = forwardRef(
     ref
   ) => {
     const { errors } = useFormikContext();
-    const inputError = getIn(errors, fieldPath, "");
+    const inputError = getIn(errors, fieldPath, undefined);
     return (
       <Form.Input
-        // need to explicitly set it as undefined, because otherwise it shows empty errors
-        // attached to the input
-        error={inputError ? inputError : undefined}
+        error={inputError}
         onClick={onClick}
         onKeyDown={onKeyDown}
         label={label}

diff --git a/...po_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/EDTFDatePickerField/utils.js b/...po_ui/theme/assets/semantic-ui/js/oarepo_ui/forms/components/EDTFDatePickerField/utils.js
@@ -12,7 +12,7 @@ export const allEmptyStrings = (arr) => arr.every((element) => element === "");
 export const serializeDate = (dateObj, dateEdtfFormat) => {
   if (dateObj === null) return "";
 
-  if (dateEdtfFormat === "yyyy") return `${dateObj.getFullYear()}`;
+  if (dateEdtfFormat === "yyyy") return dateObj.getFullYear();
   if (dateEdtfFormat === "yyyy-mm")
     return `${dateObj.getFullYear()}-${_padStart(
       dateObj.getMonth() + 1,