Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CustomFieldsComponent warning shown even if added #244

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix: CustomFieldsComponent warning shown even if added #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d2d4a2
fix: CustomFieldsComponent warning shown even if added
mesemus Oct 30, 2024
5fec283
Removed deprecation code completely
mesemus Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions oarepo_ui/resources/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,21 +73,6 @@ class UIComponentsMixin:
@property
def components(self) -> Iterator["UIResourceComponent"]:
"""Return initialized service components."""

# TODO: just for deprecation, will be removed later
for c in self.config.components or []:
if isinstance(c, CustomFieldsComponent):
break
else:
log.warning(
"CustomFieldsComponent not found in components, adding it to be backwards compatible."
)
if not self.config.components:
self.config.components = []
if isinstance(self.config.components, tuple):
self.config.components = list(self.config.components)
self.config.components.append(CustomFieldsComponent)

return (c(self) for c in self.config.components or [])

def run_components(self, action, *args, **kwargs):
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = oarepo-ui
version = 5.2.18
version = 5.2.19
description = UI module for invenio 3.5+
long_description = file: README.md
long_description_content_type = text/markdown
Expand Down
Loading