Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/paratime): Revamp paratime stats #150

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

peternose
Copy link
Contributor

@peternose peternose commented Oct 31, 2023

Changes:

  • Removed primary invoked statistics as primary workers are expected to be continuously active.
  • Introduced new statistics to monitor node's block proposals as primary or backup proposer.
  • Reorganized columns and sorted rows within the entity statistics table to improve clarity.
  • Fixed a bug that led to inaccurate statistics when the discrepancy event for the first finalized block occurred before the start block.
  • Resolved a bug that caused events from the start block to be skipped.

Testmet, sapphire:

./oasis paratime statistics 18049000 18049010

Before (10 != 9):

|                  ENTITY ADDR                   |   ENTITY NAME    | ELECTED | PRIMARY | PRIMARY INVOKED | PRIMARY GOOD COMMIT | PRIM BAD COMMMIT | PRIMARY MISSED |
|------------------------------------------------|------------------|---------|---------|-----------------|---------------------|------------------|----------------|
| oasis1qrruwg0y4au55efu0pcgl0nanaq6p3sdwv0jhzv5 | Dobrynya Hukutu4 |      10 |      10 |               9 |                   8 |                0 |              1 |

After:

|                  ENTITY ADDR                   |   ENTITY NAME    | ELECTED | PRIMARY | PRIM GOOD COMMIT | PRIM BAD COMMMIT | PRIM MISSED |
|------------------------------------------------|------------------|---------|---------|------------------|------------------|----------------|
| oasis1qrruwg0y4au55efu0pcgl0nanaq6p3sdwv0jhzv5 | Dobrynya Hukutu4 |      10 |      10 |                9 |                0 |              1 |

Before:

|                  ENTITY ADDR                   |   ENTITY NAME    | PROPOSER |
|------------------------------------------------|------------------|----------|
| oasis1qrruwg0y4au55efu0pcgl0nanaq6p3sdwv0jhzv5 | Dobrynya Hukutu4 |        2 |

After:

|                  ENTITY ADDR                   |   ENTITY NAME    | PRIMARY PROPOSER | PRIM PROPOSED | BCKP PROPOSED |
|------------------------------------------------|------------------|------------------|---------------|---------------|
| oasis1qrruwg0y4au55efu0pcgl0nanaq6p3sdwv0jhzv5 | Dobrynya Hukutu4 |                2 |             2 |             0 |

@peternose peternose force-pushed the peternose/bugfix/revamp-paratime-stats branch from 919e5d7 to 831ac66 Compare November 1, 2023 10:31
@peternose peternose enabled auto-merge November 1, 2023 10:31
Removed primary invoked statistics as primary workers are expected
to be continuously active.
Introduced new statistics to monitor node's block proposals as primary
or backup proposer.
Reorganized columns and sorted rows within the entity statistics table
to improve clarity.
Fixed a bug that led to inaccurate statistics when the discrepancy
event for the first finalized block occurred before the start block.
Resolved a bug that caused events from the start block to be skipped.
@peternose peternose force-pushed the peternose/bugfix/revamp-paratime-stats branch from 831ac66 to 493487d Compare November 1, 2023 10:34
@peternose peternose merged commit f739455 into master Nov 1, 2023
3 checks passed
@peternose peternose deleted the peternose/bugfix/revamp-paratime-stats branch November 1, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants