docs: change-parameters proposal #174
Conversation
docs/network.md
Outdated
| @@ -206,6 +206,8 @@ The following proposal types are currently supported: | |||
|
|
|||
| - `upgrade <descriptor.json>`: Network upgrade proposal. Provide a JSON file | |||
| containing the upgrade descriptor. | |||
| - `parameter-change <module-name> <changes.json>`: Network parameter change | |||
| proposal. Provide the module name and the consensus parameter changes JSON. | |||
There was a problem hiding this comment.
Is there a place where all possible module names are listed?
There was a problem hiding this comment.
These are the consensus modules. Not sure if there's a list somewhere. Idk how useful even would be listing that, someone creating a parameter change proposal needs somewhat in-depth knowledge of the oasis-core code anyway.
docs/network.md
Outdated
| @@ -206,6 +206,8 @@ The following proposal types are currently supported: | |||
|
|
|||
| - `upgrade <descriptor.json>`: Network upgrade proposal. Provide a JSON file | |||
| containing the upgrade descriptor. | |||
| - `parameter-change <module-name> <changes.json>`: Network parameter change | |||
There was a problem hiding this comment.
Let's order the proposal names by name (cancel-upgrade, parameter-change, upgrade).
| @@ -319,7 +321,7 @@ The provided ID can be one of the following: | |||
|
|
|||
| - If the [ParaTime ID] is provided, Oasis CLI shows ParaTime information stored | |||
| in the network's registry. | |||
|
|
|||
| @@ -345,7 +347,7 @@ The provided ID can be one of the following: | |||
| ParaTimes, trusted execution environment support and more. For example: | |||
|
|
|||
|  | |||
|
|
|||
There was a problem hiding this comment.
But then it's inconsistent with
Lines 341 to 343 in 818e4d4
Where it's the exact same pattern but the middle line is stripped.
There was a problem hiding this comment.
Oh, never mind. I thought it was just a leftover of yours. Yes, keep it consistent.
There was a problem hiding this comment.
Yeah it's an auto-strip by editor 😁
ptrus
force-pushed
the
ptrus/feature/create-proposal-docs
branch
2 times, most recently
from
60813bc to
1491ff4
Compare
ptrus
force-pushed
the
ptrus/feature/create-proposal-docs
branch
from
1491ff4 to
c6c04dc
Compare
| @@ -345,7 +347,7 @@ The provided ID can be one of the following: | |||
| ParaTimes, trusted execution environment support and more. For example: | |||
|
|
|||
|  | |||
|
|
|||
There was a problem hiding this comment.
Oh, never mind. I thought it was just a leftover of yours. Yes, keep it consistent.
No description provided.